-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to use custom sandbox container with Docker #6134
Comments
NOTE: this should wait until next release, i.e. the release after 0.19.0. |
@li-boxuan I have tried litearally everything and haven't been able to make a custom image work. Do you have any tips? I've spent over 40 hours trying different way. I am probably way underestimating how many hours I've tried with no luck. I just tried exactly your way and same as always I get this error: I even tried what you mentioned with the stock base image and it failed. I'm on Mac OS. I would appreciate the help if you ever figure out something! |
@amirshawn this feature is on main branch (unreleased yet), which is why I said the doc shall not be published before next release. |
@li-boxuan I ran with main:
and got an error:
This is the same error I got when running via development mode. Seems like something is broken? |
Oh, that makes sense. I can't wait for it to finally work! |
I kinda agree. It somehow works with some of my custom images but not others, even though they all used to work at some point. I tried to check out an old, verified release version but even that didn't work. My current believe is something non-deterministic inside the build logic broke it. For example, we might be pulling some dependencies in the code dynamically without specifying a fixed version. I didn't have a chance to check what has gone wrong there. That being said, my error is different from yours @mamoodi . My error is a runtime error that says the browsing environment crashed; which I tend to believe is due to some change in some 3rd party dependency. Your error is build time error. Could you please open your Docker Desktop, goto Builds tab and inspect the build history? |
An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-6134' has been created with the attempted changes. You can view the branch here. Manual intervention may be required. Additional details about the failure:
Simply documenting how to use a feature that is not working reliably does not resolve the issue. A proper resolution would require:
The documentation changes themselves appear accurate to the intended usage, but documenting a broken feature is not a complete solution. |
@openhands-agent The functionality is already released. The fact that the feature itself seems non-functional, is, to my best knowledge, due to a setting on Mac OS (so, a user error). |
A potential fix has been generated and a draft PR #6257 has been created. Please review the changes. |
A potential fix has been generated and a draft PR #6258 has been created. Please review the changes. |
docs/modules/usage/how-to/custom-sandbox-guide.md
only documents how to use a custom sandbox viaUsing the Development Workflow
.It doesn't document how to use a custom sandbox container via Docker. The correct usage should be:
The support was added by #6039
Please document it accordingly.
The text was updated successfully, but these errors were encountered: