Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Resolver] crashes on main #6037

Open
1 task done
enyst opened this issue Jan 4, 2025 · 11 comments · May be fixed by #6284
Open
1 task done

[Bug]: [Resolver] crashes on main #6037

enyst opened this issue Jan 4, 2025 · 11 comments · May be fixed by #6284
Labels
bug Something isn't working fix-me-experimental resolver Related to OpenHands Resolver

Comments

@enyst
Copy link
Collaborator

enyst commented Jan 4, 2025

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

It seems the resolver is broken on main: I ran with the label fix-me-experimental and got

ERROR:root:<class 'AttributeError'>: 'NoneType' object has no attribute 'logs'
Exception ignored in: <function LogStreamer.del at 0x7ff5a8fa8220>
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/openhands/runtime/utils/log_streamer.py", line 41, in del
AttributeError: 'LogStreamer' object has no attribute 'stdout_thread

Log: https://github.com/All-Hands-AI/OpenHands/actions/runs/12614710302/job/35153871943?pr=6036#step:10:49

It ran on a PR: #6036 (comment)

OpenHands Installation

Other

OpenHands Version

main 56d7dcc

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@enyst enyst added the bug Something isn't working label Jan 4, 2025
@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Jan 5, 2025
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 5, 2025

Considering how fast things are moving and the amount of change, would it make sense to change this line:

uses: All-Hands-AI/OpenHands/.github/workflows/openhands-resolver.yml@main

to a specific version/tag? I feel like pointing to main may make this a little unstable.

@enyst
Copy link
Collaborator Author

enyst commented Jan 5, 2025

Well, the resolver has 2 modes basically, from this point of view:

  • it runs on the latest version <= when it's triggered by the label fix-me or we insert the tag @openhands-agent in a comment
  • it runs on main <= when it's triggered by the label fix-me-experimental or we use the tag @openhands-agent-exp in a comment.

So we can choose the stable version, we just have the additional ability to run on main. Livin' on the edge! 😅

Other repos are also able to run on a target branch / main, which uses our main as you pointed out.

(On a side note, that's why we're not sure how to classify these bugs. I do think they're bugs anyway, and they will be in the stable version if we let them (except for the rare case when versioning itself was the problem).

@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@enyst
Copy link
Collaborator Author

enyst commented Jan 5, 2025

Oops, haha it heard me 😂

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 5, 2025

What's the difference between the "latest version" and "main"? Does latest version mean latest stable version?

@enyst
Copy link
Collaborator Author

enyst commented Jan 5, 2025

Yes! It's 0.18 now

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 5, 2025

Oh that's good to know. So when someone copies this : https://github.com/All-Hands-AI/OpenHands/blob/main/openhands/resolver/examples/openhands-resolver.yml

To their repo and they tag "fix-me" or use its name. Does it also use the latest stable version? Or does it use main?

@enyst
Copy link
Collaborator Author

enyst commented Jan 5, 2025

Let's see!

Looks like it's 0.18.0, if the label is fix-me:

####openhands-ai==0.18.0

Workflow: https://github.com/enyst/litellm/actions/runs/12622492557/job/35170464204#step:4:67

But I'm getting confused. I think it got the workflow file from main, then it executes on 0.18.0... 🤔

@DylanLIiii
Copy link

DylanLIiii commented Jan 5, 2025

Hi @enyst,

I encountered a similar issue and wanted to share my findings. After reviewing the label issue you mentioned, I discovered that the root cause seems to stem from an incorrect installation of OpenHands. This appears to be related to the workflow file, specifically codes around the cat Requirements.txt command. Instead of appending dependencies correctly to the last line, it adds them immediately after the last character in the file.

This behavior causes pip to fail in recognizing the corresponding package, leading to installation issues. For reference, you can check my issue here: #5988. In my case, the Requirements.txt file from my repository was used, and the version characters for openhands_ai were appended incorrectly at the end of the last line, causing the installation to fail.

I hope this helps in identifying and resolving the problem!

@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@openhands-agent
Copy link
Contributor

A potential fix has been generated and a draft PR #6284 has been created. Please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me-experimental resolver Related to OpenHands Resolver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants