-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: [Resolver] crashes on main
#6037
Comments
Considering how fast things are moving and the amount of change, would it make sense to change this line:
to a specific version/tag? I feel like pointing to main may make this a little unstable. |
Well, the resolver has 2 modes basically, from this point of view:
So we can choose the stable version, we just have the additional ability to run on Other repos are also able to run on a target branch / main, which uses our (On a side note, that's why we're not sure how to classify these bugs. I do think they're bugs anyway, and they will be in the stable version if we let them (except for the rare case when versioning itself was the problem). |
Oops, haha it heard me 😂 |
What's the difference between the "latest version" and "main"? Does latest version mean latest stable version? |
Yes! It's 0.18 now |
Oh that's good to know. So when someone copies this : https://github.com/All-Hands-AI/OpenHands/blob/main/openhands/resolver/examples/openhands-resolver.yml To their repo and they tag "fix-me" or use its name. Does it also use the latest stable version? Or does it use main? |
Let's see!
Looks like it's 0.18.0, if the label is
Workflow: https://github.com/enyst/litellm/actions/runs/12622492557/job/35170464204#step:4:67 But I'm getting confused. I think it got the workflow file from main, then it executes on |
Hi @enyst, I encountered a similar issue and wanted to share my findings. After reviewing the label issue you mentioned, I discovered that the root cause seems to stem from an incorrect installation of OpenHands. This appears to be related to the workflow file, specifically codes around the cat Requirements.txt command. Instead of appending dependencies correctly to the last line, it adds them immediately after the last character in the file. This behavior causes pip to fail in recognizing the corresponding package, leading to installation issues. For reference, you can check my issue here: #5988. In my case, the Requirements.txt file from my repository was used, and the version characters for openhands_ai were appended incorrectly at the end of the last line, causing the installation to fail. I hope this helps in identifying and resolving the problem! |
A potential fix has been generated and a draft PR #6284 has been created. Please review the changes. |
Is there an existing issue for the same bug?
Describe the bug and reproduction steps
It seems the resolver is broken on
main
: I ran with the labelfix-me-experimental
and gotLog: https://github.com/All-Hands-AI/OpenHands/actions/runs/12614710302/job/35153871943?pr=6036#step:10:49
It ran on a PR: #6036 (comment)
OpenHands Installation
Other
OpenHands Version
main 56d7dcc
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response
The text was updated successfully, but these errors were encountered: