You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I am creating an issue because even though the project seems quite interesting, the code quality (from what I saw) is at best okay-ish, at worst simply bad, be it from only PEP8 weirdness, or non-pythonicness alone.
Though I do not mean to be disrespectful to all the contributors, it seems that the lack of code review is a cause of overall poor code quality on this repo.
I would love to help review code and contribute on my free time, but improving the current code is a daunting task that I cannot undertake alone.
I also know that reviewing code alone is really tedious, and that it would slow the contribution rate, and I understand if you don't want to integrate review in the workflow.
Sincerely,
Amaras
The text was updated successfully, but these errors were encountered:
hey, @Amaras I completely agree with you. Code quality really matters we should give a test so that only when the test passes someone can merge the PR.
Hi! I am creating an issue because even though the project seems quite interesting, the code quality (from what I saw) is at best okay-ish, at worst simply bad, be it from only PEP8 weirdness, or non-pythonicness alone.
Though I do not mean to be disrespectful to all the contributors, it seems that the lack of code review is a cause of overall poor code quality on this repo.
I would love to help review code and contribute on my free time, but improving the current code is a daunting task that I cannot undertake alone.
I also know that reviewing code alone is really tedious, and that it would slow the contribution rate, and I understand if you don't want to integrate review in the workflow.
Sincerely,
Amaras
The text was updated successfully, but these errors were encountered: