Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving code quality? #102

Open
Amaras opened this issue Oct 4, 2020 · 1 comment
Open

Improving code quality? #102

Amaras opened this issue Oct 4, 2020 · 1 comment

Comments

@Amaras
Copy link

Amaras commented Oct 4, 2020

Hi! I am creating an issue because even though the project seems quite interesting, the code quality (from what I saw) is at best okay-ish, at worst simply bad, be it from only PEP8 weirdness, or non-pythonicness alone.
Though I do not mean to be disrespectful to all the contributors, it seems that the lack of code review is a cause of overall poor code quality on this repo.

I would love to help review code and contribute on my free time, but improving the current code is a daunting task that I cannot undertake alone.
I also know that reviewing code alone is really tedious, and that it would slow the contribution rate, and I understand if you don't want to integrate review in the workflow.

Sincerely,
Amaras

@abdoulayegk
Copy link

hey, @Amaras I completely agree with you. Code quality really matters we should give a test so that only when the test passes someone can merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants