Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default ATM10 configuration causes visual lava issue between Complementary Shaders and Fireproof Boats #1530

Closed
fwishky opened this issue Dec 25, 2024 · 0 comments
Labels
Suggestion New feature or request

Comments

@fwishky
Copy link

fwishky commented Dec 25, 2024

Possible Fixes

Yes

Modpack Version

2.10

What happened?

In the latest version of ATM10 as of writing, the default mod configuration causes a visual bug between Complementary Shaders (included in ATM10) and Fireproof Boats. This may affect other shaders, but I have not tried them, so I am not sure.

Complementary Shaders has several different options pertaining to the appearance of lava, such as wavy lava and the lava edge effect. The changeLavaRenderType config option (set to true by default) in Fireproof Boats (fireproofboats-client.toml) modifies the rendering behaviour of lava, preventing Complementary Shaders from modifying lava source blocks (flowing blocks are unaffected), resulting in an "odd" look. This does not affect gameplay, but may confuse those who have used the shader before and are familiar with what it should look like. Lava also appears slightly translucent.
Setting this config option to false fixes this issue.

I do not believe this is a "bug" with Fireproof Boats, as the config upfront says that it modifies the rendering of lava, so I have not opened an issue on the mod developer's github. I am simply requesting a default configuration change with the pack to ensure that shaders that are included by default look properly.

Shown below are two screenshots comparing ATM10 and an instance with only Iris and Sodium; both are running the same settings (Complementary r5.3 Unbound + EuphoriaPatches 1.4.3 Ultra preset with a few EuphoriaPatches settings turned on)

ATM10 2.10 with default configuration
javaw_20241224_202945

Minecraft 1.21.1 with just Iris and Sodium
javaw_20241224_202613

latest.log

No response

Developer reports

No response

@fwishky fwishky added the Bug Something isn't working label Dec 25, 2024
alekthefirst added a commit to alekthefirst/ATM-10 that referenced this issue Dec 25, 2024
Disables lava rendering from fireproof boats to restore the behavior intended from shaders. See AllTheMods#1530
Cons of this change: Lava from wave effects will be visible inside the fireproof boats
@alekthefirst alekthefirst added Suggestion New feature or request and removed Bug Something isn't working labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants