1.19: Accessing LegacyRandomSource from multiple threads

[McNasties]

IllegalStateException randomly. Freezes, saves game, and closes.
crash-2022-11-21_10.11.44-client.txt

[roguethedev]

Hello I'm having similar error. This error occurs just randomly, sometimes take hours or maybe minutes.

I'm playing Singleplayer at Mac M1 Pro 16gb using Curse Forge app to launch, I didnt change nothing at the modpack files

Description: Accessing LegacyRandomSource from multiple threads

crash-2022-11-29_13.52.50-client.txt

crash-2022-11-29_13.39.18-server.txt

I don't know if is the map corrupt, or if the Mac its not recomend to play ATM, any help will be welcome.

[NoMoreStars]

Just got a similar crash as well

[Ninjawolf0007]

I thought this was related to an EvilCraft issue, but after the update to version 1.0.7 of ATM8, I'm also seeing this crash seemingly unrelated to a specific mod from what I can gather.
crash-2022-12-24_14.58.42-client.txt

[ghost]

I believe this is caused by Supplementaries which in this commit here
common/src/main/java/net/mehvahdjukaar/supplementaries/common/block/blocks/PedestalBlock.java:152
introduces a piece of code that apparently is thread unsafe and can cause crashes like this

This change is included in ATM 8 1.0.7

Edit: level.random seems to be used several places in the Supplementaries update

[TelepathicGrunt]

@alekthefirst No, the block's use method is ran only on server thread where it is safe to use level.random. The issue is someone is using the level's random on an off thread instead of server thread. Common places people accidentally misuse the wrong random is during worldgen or within entity constructors/finalizeSpawn mehods which also runs on off thread during worldgen. Nothing in that Supplementaries commit stands out.

[TelepathicGrunt]

EvilCraft did make a change in dev to fix the randomsource crash as they seemed to have narrowed down themselves as a potential cause of it: CyclopsMC/EvilCraft@b03ed5e

Or at least shield themselves so they can't be blamed for someone else's misuse of the random sources (If EvilCraft was actually a victim)

[Mitchell5200]

Mod at fault identified, and mod dev contacted,
Duplicate of #307, #447, #553, #580, #649

[Mitchell5200]

Fixed in 1.0.9