Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash]: value must be non-negative crash with allthemodium #124

Open
PikachuGabe opened this issue Sep 12, 2024 · 4 comments
Open

[Crash]: value must be non-negative crash with allthemodium #124

PikachuGabe opened this issue Sep 12, 2024 · 4 comments
Labels
Crash Game Crash

Comments

@PikachuGabe
Copy link

PikachuGabe commented Sep 12, 2024

Possible Fixes

Yes

Modpack Version

ATM10 - 0.48

What happened?

A player died with an item on them with a negative durability or max durability(unsure which yet) the attempt at creative a grave causes a "value must be non-negative number" exception and thus crash. Easiest way to test is likely getting an allthemodium pickaxe(as that's what caused a crash on my server) and dying then collecting the grave
Could be collecting a grave with a negative damage and max damage item or just dying with one, I cannot get on my pc to test.
For right now I will see if I can manually patch the version of allthemodium on my server. I would directly report this to allthemodium if there was an issue page for that, but the mod is owned by ATMTeam so this should work.

Crash Log

crash-2024-09-12_20.31.36-server.txt

Latest.Log

2024-09-12-1.log

@PikachuGabe
Copy link
Author

I tried reporting it to the gravestone mod but they said it was from allthemodium and cannot be fixed by them.

@PikachuGabe
Copy link
Author

I have found the responsible lines of code but given the closed source nature of the mod i dont believe i can send the code itself here. Once I successfully recompile the mod(as wifi issues have been causing my compiler to die) I will send the recompiled version here so it may be implemented.

@PikachuGabe
Copy link
Author

Havnt had wifi for a while so theres been no progress. Working on getting wifi back.

@PikachuGabe
Copy link
Author

PikachuGabe commented Sep 15, 2024

finally got wifi back. i cannot get this shit to compile though...
maybe intellij will be better for decompiling it in the first place.

cant get shit to work. screw it, im editing the binary directly

not even that worked

@TheBedrockMaster TheBedrockMaster added the Crash Game Crash label Nov 24, 2024
@TheBedrockMaster TheBedrockMaster transferred this issue from AllTheMods/ATM-10 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash Game Crash
Projects
None yet
Development

No branches or pull requests

2 participants