Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerStart.bat doesn't support IPv6 #88

Open
algorythm opened this issue Jan 12, 2022 · 0 comments · May be fixed by #89
Open

ServerStart.bat doesn't support IPv6 #88

algorythm opened this issue Jan 12, 2022 · 0 comments · May be fixed by #89

Comments

@algorythm
Copy link

Starting the server won't work on Windows if you have a public IPv6 address.

The script makes a ping to minecraftforge.net and tries to look for TTL in the response. Apparently, if the server returns an IPv6 address, the TTL is not included:

image

As I personally have a public IPv6 address, the server responds with IPv6 as well, causing the script to think, that I don't have internet.

The bash script uses the return code of the ping command instead of asserting on the output, so the issue only shows up on Windows.
algorythm added a commit to algorythm/Server-Scripts that referenced this issue Jan 12, 2022
@algorythm
Force IPv4 ping in ServerStart.bat when using DNS resolution
624f569 
Ping does not respond with a TTL if the server responds with an IPv6
address. This essentially means that the script will think the user does
not have internet, if they have a public IPv6 address. Forcing IPv4 in
the ping command, ensures TTL gets returned, and the startup can
proceed.

This issue is only relevant in the batch script, as that is the only
script that asserts on TTL being present in the output. It is also only
an issue when pinging minecraftforge.net, as that relies on DNS
resolution. This means the output differs if the DNS server returns IPv4
(the A record) or IPv6 (the AAAA record).

Closes AllTheMods#88
@algorythm algorythm linked a pull request Jan 12, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force IPv4 ping in ServerStart.bat when using DNS resolution algorythm/Server-Scripts
1 participant
@algorythm