Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement run-time testing #413

Closed
5 tasks done
t0mpr1c3 opened this issue Aug 6, 2020 · 4 comments · Fixed by #420
Closed
5 tasks done

Implement run-time testing #413

t0mpr1c3 opened this issue Aug 6, 2020 · 4 comments · Fixed by #420

Comments

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Aug 6, 2020

@dl1com
Copy link
Contributor

dl1com commented Aug 17, 2020

Some thoughts on the "Test" button:

  • What do you think about moving the "Test" button into the "Tools" section of the menu bar? I think/hope it is not that frequently used.
  • If the button shall stay where it currently (b1252f6) is, then there is a race condition between the "Test" button and the enabled state of the port selection combo box. Currently, the "Tests" button is active after starting the software, but the combo box is not, because no pattern has been selected. So we might just enable the port selection UI elements on startup as well.

Test mode looks really nice, I am happy that this feature finally made it to the main software. Thanks a lot for that!
What do you think about removing the input text box and just use buttons (or a combo box and a send button) to trigger the various test functions? I could imagine that some users find it to be tedious to type in the commands manually.

@t0mpr1c3
Copy link
Contributor Author

Thanks Chris, these are great suggestions! very constructive and helpful, and I think should lead to some real improvements.

  • What do you think about moving the "Test" button into the "Tools" section of the menu bar? I think/hope it is not that frequently used.

That's a good idea. I think perhaps on the Tools submenu?

  • If the button shall stay where it currently (b1252f6) is, then there is a race condition between the "Test" button and the enabled state of the port selection combo box. Currently, the "Tests" button is active after starting the software, but the combo box is not, because no pattern has been selected. So we might just enable the port selection UI elements on startup as well.

Yes, and actually that is easily done because they are not part of the DockWidget UI.

What do you think about removing the input text box and just use buttons (or a combo box and a send button) to trigger the various test functions? I could imagine that some users find it to be tedious to type in the commands manually.

That makes sense. And if we are going that route we might as well hard-code the test commands into the API, which would simplify the firmware considerably.

The API changes are the most fundamental, so that is the thing that would need to be done first.

@t0mpr1c3
Copy link
Contributor Author

t0mpr1c3 commented Aug 26, 2020

@X-sam
Copy link
Member

X-sam commented Feb 24, 2023

Can we close this? New to the codebase and trying to run down the 1.0 milestone tasks and figure out what's still outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants