Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reqTest bug #171

Closed
t0mpr1c3 opened this issue Oct 18, 2023 · 1 comment · Fixed by #172 · May be fixed by #154
Closed

reqTest bug #171

t0mpr1c3 opened this issue Oct 18, 2023 · 1 comment · Fixed by #172 · May be fixed by #154
Assignees
@t0mpr1c3
Labels
bug ready - please test
Milestone
1.0.0

Comments

@t0mpr1c3
Copy link
Contributor

The firmware expects reqTest to be a 2-byte message with the second byte specifying machine type, but the API specifies a 1-byte message, and that was what the desktop is been sending.

This bugfix changes the firmware to be consistent with APIv6 and may close AllYarnsAreBeautiful/ayab-desktop#461
@t0mpr1c3 t0mpr1c3 added the bug label Oct 18, 2023
@t0mpr1c3 t0mpr1c3 linked a pull request Oct 18, 2023 that will close this issue
Finite Machine states inherit from OpInterface #154
Draft
@t0mpr1c3 t0mpr1c3 mentioned this issue Oct 18, 2023
Merged
@t0mpr1c3 t0mpr1c3 added this to the v1.0 milestone Oct 18, 2023
@t0mpr1c3 t0mpr1c3 linked a pull request Oct 18, 2023 that will close this issue
Fix reqTest bug #172
Merged
@t0mpr1c3 t0mpr1c3 self-assigned this Oct 18, 2023
@jonathanperret
Copy link
Contributor

Fix tested as working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0mpr1c3 t0mpr1c3

Labels
bug ready - please test
Projects
None yet
Milestone
1.0.0
2 participants
@jonathanperret @t0mpr1c3