Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set solenoids as a group instead of individually in Knitter::knit() #92

Open
t0mpr1c3 opened this issue Jun 17, 2023 · 2 comments
Open

Set solenoids as a group instead of individually in Knitter::knit() #92

t0mpr1c3 opened this issue Jun 17, 2023 · 2 comments
Labels
code quality enhancement
Milestone
next

Comments

@t0mpr1c3
Copy link
Contributor

Currently Knitter::knit() sets solenoids pixel-by-pixel as the carriage passes over the needles. This is inefficient because the solenoids can be set as a group and do not need to be updated individually.
@dl1com
Copy link
Contributor

dl1com commented Jun 17, 2023

May be the case, but this definitely needs testing with a machine to verify.

@dl1com dl1com added this to the next milestone Jul 2, 2023
@t0mpr1c3 t0mpr1c3 mentioned this issue Sep 6, 2023
Merged
@t0mpr1c3
Copy link
Contributor Author

See #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality enhancement
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@dl1com @t0mpr1c3