Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Pull Request #3 #5

Open
dl1com opened this issue Apr 20, 2019 · 2 comments
Open

Improvements for Pull Request #3 #5

dl1com opened this issue Apr 20, 2019 · 2 comments

Comments

@dl1com
Copy link
Contributor

dl1com commented Apr 20, 2019

From comments done by @Adrienne200 in Pull Request #3

Single Bed:
Remove the sentence about needing an even number of pixels.
Remove the duplicate sentence starting "To create your own patterns.."
Remove the sentence that starts "Use thin yarns.. (thin yarns and suggesting Woolike is OK advice but not really necessary here; I hope people already know what kind of yarn to use for everyday knitting) but the second half of that sentence is wrong here, for fair Isle we are not using both beds.

DBJ:
And on the DBJ page, you're correct that the DBJ section could use a little more introduction, but I don't think that particular book reference adds much, and I don't want people to think that I recommend buying it. I'd never heard of it, looking at it on Amazon it doesn't look to be particularly useful to the hobby knitter, even a dedicated one such as myself. I'm quite interested in learning about industrial knitting, but most hobby knitters have only a passing interest in the topic and probably should not spend $80+ on this book. If you still want to recommend it, maybe it belongs in the FAQ?

I'll think of a few sentences introducing DBJ and mentioning that this just one of several choices of backings, maybe include a more commonly-available reference book.

@DerAndere1
Copy link
Contributor

DerAndere1 commented Apr 21, 2019

See pull request #7

@DerAndere1
Copy link
Contributor

DerAndere1 commented Apr 29, 2019

@Adrienne200 the current master branch (https://github.com/AllYarnsAreBeautiful/ayab-manual/tree/master/docs/how_to_knit ) should have incorporated your suggestions. If you are happy with the result, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants