Codegen refactor #273
Merged
Codegen refactor #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we all like small functions (not one large beast) - Now I moved flags stuff to flags.go - I've also added a special function to validate json paths
- we all love small, nice to read functions - I've extractred json loading stuff into separated function - over that, I've added a small helper struct to store that data
now I'll try to enhance data flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We all love object programming right? 😄
I've organised
main.goint a few, handy objects.One of these objects called
Contextis passed through the whole generator (instead of a bunch of maps).Also, now all generators uses maps by default so that checking if certain name is present in map is super easy.