Add AddressBook to InputAddress component #1672
Assignees
Labels
Comments
|
@asif-finimble you'll have to check in Zeplin to see if the design has changed since the issue was created. Do you have access to Zeplin? |
Yes, I have access to Zeplin. Will check it out. |
|
@JamesSmartCell I think the AddressBook is not implemented, is it? I cant find any branch for it. I remember implementing this in Bartercard. |
|
@JamesSmartCell , for EditAddress Screen, we should allow user to edit only name right? Because Address -> name is 1-1 relationship. Also address is primary key here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AddressBook enhancement needs to be added to the InputAddress component:
https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76
Here's the AddressBook screen detail:
https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address
Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.
The addressbook should be switchable from the layout via a
custom:addressbook="true"kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.It may also need an entry in the settings page; check the zeplin spec.
You should work off the 'Component Upgrade' branch, as the new components are on that one.
The text was updated successfully, but these errors were encountered: