Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence of Obfuscated and Minified JavaScript Files in Test Suite Poses Security Risk And Loss of User Data #29

Closed
vetalapo opened this issue Feb 20, 2024 · 1 comment

Comments

@vetalapo
Copy link

Hello there,

I hope this message finds you well. I am writing to bring your attention to a critical issue identified in the test suite of the basic-js-ds GitHub repository. The concern revolves around the presence of obfuscated and minified JavaScript files within the test suite, for which no corresponding source code is available.

Issue Description:
The current state of the test suite includes JavaScript files that have been obfuscated and minified, making it impossible to review and rebuild the code to confirm its content. This lack of transparency raises serious security concerns, as it introduces the risk of potential malicious code that could compromise the integrity of the repository and, consequently, the security of user data.

Potential Implications:
Security Risk: The obfuscated code may contain malicious elements that could compromise the security of the entire repository and, consequently, user data.

Inability to Verify Code:
Without access to the source code, it is challenging to verify the legitimacy and security of the obfuscated and minified files.

Proposed Possible Actions:

  1. Remove files with obfuscation
  2. Add description into README
    Unfortunately similar proposition was met harshly at RSSchool and was closed upon opening PR: docs: update readme with additional info on test functions obfuscation rolling-scopes-school/core-js-conditions-n-loops-tasks#18
  3. Introduce running test in a Docker container, this way if a person doesn't trust obfuscation, they can run the tests in a isolated container. Similar to following:
    https://github.com/vetalapo/rsschool-projects/blob/main/basic-js-ds/Dockerfile
@AlreadyBored
Copy link
Owner

Hi, see answer here AlreadyBored/basic-js#164 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants