Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be ideal to integrate the CloudFlare changes #23

Open
rvowles opened this issue Jul 30, 2017 · 1 comment
Open

It would be ideal to integrate the CloudFlare changes #23

rvowles opened this issue Jul 30, 2017 · 1 comment

Comments

@rvowles
Copy link

rvowles commented Jul 30, 2017

from here: https://github.com/cloudflare/kyototycoon

@carlosefr
Copy link
Contributor

That would be interesting, and some minor ones have already been integrated (eg. 93d6a80).

What's missing:

  • TLS-encrypted connections (mostly for secure replication);
  • Alternative Base64 implementation, from Google.

These haven't been integrated for two reasons:

  • Encrypted replication can be achieved outside the scope of ktserver, but mostly because this would have to be an optional (compile-time) feature and would increase maintenance burden (keeping up with new OpenSSL releases, such as the 1.0.x -> 1.1.x changes);
  • The need for an alternative Base64 implementation would have to be demonstrated, beyond the specific reasons why CloudFlare needs it.

I'm not part of Altice Labs anymore, but I would be willing to test them in my fork (https://github.com/carlosefr/kyoto) provided someone would break these modifications into smaller bits/commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants