Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support s3:// in <endpoint> section during parse object disk configuration #1035

Open
Slach opened this issue Oct 28, 2024 · 5 comments
Open
Assignees
Milestone

Comments

@Slach
Copy link
Collaborator

Slach commented Oct 28, 2024

No description provided.

@Slach Slach added this to the 2.6.3 milestone Oct 28, 2024
@Slach Slach self-assigned this Oct 28, 2024
@Slach Slach modified the milestones: 2.6.3, 2.6.4 Nov 4, 2024
@mithunputhusseri
Copy link
Contributor

Hi @Slach Is it possible for me to work on this enhancement?. If yes, can I get more context on the requirement, any details on the development life cycle and setting up the dev environment.

@Slach
Copy link
Collaborator Author

Slach commented Nov 29, 2024

don't be shy make pull request
look pkg/storage/object_disk/object_disk.go -> getObjectDisksCredentials
add e2e test in test/integration/ or test/testflows

@mithunputhusseri
Copy link
Contributor

Hi @Slach Can you share steps i can follow to run integration test locally. All the containers are up except the clickhouse server container. Failing with AWS S3 auth error. Should i setup an external AWS S3 endpoint for testing. I thought i could test with minio S3 container.

@Slach
Copy link
Collaborator Author

Slach commented Nov 30, 2024

you need only worked docker compose

RUN_TESTS=TestNameRegexp ./test/integration/run.sh
RUN_TESTS=TestNameRegexp ./test/testflows/run.sh

@Slach
Copy link
Collaborator Author

Slach commented Nov 30, 2024

Should i setup an external AWS S3 endpoint for testing.

Look .env.example
rename to .env
and provide some credentials

@Slach Slach modified the milestones: 2.6.4, 2.6.5 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Slach @mithunputhusseri and others