Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GenericCloudEventXacmlMapper to add org/app attributes for app events #337

Open
5 tasks
Tracked by #311
acn-sbuad opened this issue Apr 26, 2023 · 1 comment
Open
5 tasks
Tracked by #311
Labels
kind/user-story Used for issues that describes functionality for our users. status/pending-feedback Awaiting clarification/input from stakeholders etc.

Comments

@acn-sbuad
Copy link
Contributor

acn-sbuad commented Apr 26, 2023

Description

We will need to add additional attributes to all XacmlRequests for events related to an Altinn App.
They should have the org, app, partyid and instance-id attributes included in the request.

We need to add these two parameters to the request if the event represents an app resource.

Consider if this means we should continute to keep the AppCloudEventXacmlMapper or if the logic can be included in GenericCloudEventXacmlMapper as a if check for instance.

Considerations

  • The verb to authorize on is also different. Subscribe vs read. Might point to a need to keep the AppCloudEventXacmlMapper separate.

Tasks

  • Development
  • QA
  • Test
  • Automated tests

Acceptance criteria

  • You can successfully query app events from the /events endpoint and a non empty result set
@acn-sbuad acn-sbuad changed the title Extend GenericCloudEventXacmlMapper to add org/app attributes for app events, dependent on altinn/altinn-resource-registry#153 Extend GenericCloudEventXacmlMapper to add org/app attributes for app events Apr 26, 2023
@acn-sbuad acn-sbuad added the kind/user-story Used for issues that describes functionality for our users. label Apr 26, 2023
@SandGrainOne
Copy link
Member

@TheTechArch What is the timeline for moving apps into resource registry.

@olebhansen olebhansen added the status/pending-feedback Awaiting clarification/input from stakeholders etc. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users. status/pending-feedback Awaiting clarification/input from stakeholders etc.
Projects
None yet
Development

No branches or pull requests

3 participants