Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out - in code - where to log entries #658

Open
4 tasks
eskebab opened this issue Feb 11, 2025 · 1 comment
Open
4 tasks

Figure out - in code - where to log entries #658

eskebab opened this issue Feb 11, 2025 · 1 comment
Assignees

Comments

@eskebab
Copy link
Contributor

eskebab commented Feb 11, 2025

Problem
We need to figure out where to log entries so that we can troubleshoot missing events better. What is considered valuable information? What information gives us a better in-detail view of where events are lost?

Solution
The Webhook Service is responsible for posting an event to a consumer's endpoint. We log the response from this POST request to our log service by posting the event to the Storage Controller.

  • Create new api endpoint in StorageController with PlatformAccess authorization policy. "/storage/logs POST
  • Log when event is authorized and pushed to outbound queue in OutboundController
  • When subscription is not authorized and event is not added to outbound queue
  • Other log entries may be relevant based on outcome of discussion issue Unresolved events logging issues: For discussion #662
@eskebab eskebab changed the title Find all Figure out - in code - where to log entries Feb 11, 2025
@eskebab eskebab self-assigned this Feb 21, 2025
@eskebab eskebab mentioned this issue Feb 25, 2025
5 tasks
@eskebab
Copy link
Contributor Author

eskebab commented Mar 11, 2025

a couple more minor tasks:

  • log errors with more detailed information
  • add try catch to function project
  • don't try catch in storage controller. avoid returning 500 status code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant