Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Should @o3r/create generate a husky hooks configuration? #2663

Open
malek-benazzouz opened this issue Jan 6, 2025 · 0 comments · May be fixed by #2682
Open

[Feature]: Should @o3r/create generate a husky hooks configuration? #2663

malek-benazzouz opened this issue Jan 6, 2025 · 0 comments · May be fixed by #2682
Assignees
Labels
enhancement New feature or request triage

Comments

@malek-benazzouz
Copy link

Context

When generating a project using @o3r/create, do we want the generator to automatically generate a husky hooks configuration?
If we do not want it to be included by default, we could provide a schematic that can be run on demand, similarly to the ng add @o3r/eslint-config command.

Proposal

The default configuration could be the following one.

Packages to install:

npm install --save-dev husky
npx husky init

npm install --save-dev lint-staged
npm install --save-dev editorconfig-checker
npm install --save-dev @commitlint/{cli,config-conventional}

Configuration files to fill:

  • Add lint-staged config in package.json file.
  • Create and fill .commitlintrc.json config file.
  • Create and fill .husky/commit-msg and .husky/pre-commit scripts.

Example in this PR: https://github.com/amadeus-digital/nevio-cockpit/pull/6/files

@malek-benazzouz malek-benazzouz added enhancement New feature or request triage labels Jan 6, 2025
@kpanot kpanot added this to the On boarding improvement milestone Jan 7, 2025
@kpanot kpanot self-assigned this Jan 9, 2025
@kpanot kpanot linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants