Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 Targeting DSL - UnifiedNumber instead of BigNumber #67

Open
2 tasks
elpiel opened this issue Jun 16, 2021 · 0 comments
Open
2 tasks

V5 Targeting DSL - UnifiedNumber instead of BigNumber #67

elpiel opened this issue Jun 16, 2021 · 0 comments

Comments

@elpiel
Copy link
Member

elpiel commented Jun 16, 2021 •
edited
Loading

We are moving out of using BigNumber to the UnifiedNum (with precision 8), the DSL should follow this change and use UnifiedNum for all the prices and numbers requiring it.

The function typecasting bn will not require changing

  • Change the wording to use UnifiedNumber instead of BigNumber
  • Remove getPriceInUSD DSL function PR targetingAndBidding - remove the fn getPriceInUSD #68
    After the introduction of UnifiedNum we no longer need this function. The UnifiedNum reflects the price in USD as we use stable coins pegged to USD.

https://github.com/AdExNetwork/adex-protocol/blob/27a1bd5d4a726bb246af032ff44ae6a7b7652e11/targetingAndBidding.md
@elpiel elpiel changed the title V5 Targeting DSL - UnifiedNum instead of BigNumber V5 Targeting DSL - UnifiedNumber instead of BigNumber Jun 16, 2021
This was referenced Jun 16, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elpiel