Contribution page #78
Conversation
packages/web/tests/components/Contributions/ContributionsBox.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/Contributions/ContributionsBox.test.tsx
Outdated
Show resolved
Hide resolved
| </Box> | ||
| <Box mt="1">Score: {cbox.score}</Box> | ||
| <Box mt="1" color="gray" fontSize="xs"> | ||
| {cbox.contributedAt.toString().slice(0, 10)} |
There was a problem hiding this comment.
Pull in the DateTime component from the Luxon library and use it here (and perhaps even use relative time in a meaningful way in addition to absolute time)
|
|
||
| export const ContributionsBox: React.FC<ContributionsBoxProps> = ({ cbox }) => { | ||
| return ( | ||
| <Box maxW="sm" borderWidth="1px" borderRadius="lg" overflow="hidden" key={cbox.id}> |
There was a problem hiding this comment.
Let's hop on a call and chat about this style stuff; I think there's likely a simpler way to do this using additional Chakra components
| // Get all Contributions | ||
| const res = await fetch('/api/contributions'); | ||
| const ContributionsList = await res.json(); | ||
|
|
There was a problem hiding this comment.
We need to wrap this in a try catch and we also need to make sure that res.ok is truthy before continuing. If there's an error, we should display it meaningfully to the user via an Alert
| }; | ||
|
|
||
| describe('Contributions Box', () => { | ||
| it('renders', async () => { |
There was a problem hiding this comment.
Checking to see if it renders is not sufficient. Change this description and add more meaningful evaluations to the test below (like whether the fields within a contribution box render as expected and whether the link is clickable)
| // Wait utility | ||
| const wait = () => new Promise<void>((resolve) => setTimeout(() => resolve(), 0)); |
There was a problem hiding this comment.
Delete this and use the waitForutility
github-actions
bot
added
the
migration may be needed
Pre-Requisites
Description of Changes
Related Issues