Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to crash on start when required vars are not set #26

Open
1 task done
SpencerKaiser opened this issue May 18, 2021 · 1 comment
Open
1 task done
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SpencerKaiser
Copy link
Contributor

Pre-requisites:

Feature Description

simple-env should include an option to fail to start if a required variable is not set; this would prevent the app from starting but failing in prod because something required was missing at runtime.

For example, a Slack token necessary to respond to an event may be unset when the app starts, the app could start successfully, blue green could swap the apps successfully, and the app would then be in a broken state.

@SpencerKaiser SpencerKaiser added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 18, 2021
@johnkahn
Copy link
Contributor

I think this should actually be the default and we should have an option to disable it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants