First add for minizip

[ryanskeith]

Minizip 4.0.3

Destination channel:
main

Links

• 3669
• Upstream repository

Explanation of changes:

• added gtest to avoid code from downloading from source and building
• added gtest to ignore_run_exports as it is a test dependency and not a run dependency

[danpetry]

A few comments for where I couldn't put comments in the code:

• probably better to explicitly state the build optionsthat are being used, for documentation purposes. I mean the ones that are default on and are already being used because the dependencies are there in the host environment
• you could build tests and unit tests for windows too
• do you know why the static library is included in the package for windows but not unix?
• also why CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is on?

[ryanskeith]

A few comments for where I couldn't put comments in the code:

• probably better to explicitly state the build optionsthat are being used, for documentation purposes. I mean the ones that are default on and are already being used because the dependencies are there in the host environment
• you could build tests and unit tests for windows too
• do you know why the static library is included in the package for windows but not unix?
• also why CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is on?

• That's a good idea on being explicit. I will flesh those out.

• I will try adding tests for windows.

• I do not know why static libs are included in the package for windows and not unix.

• I am not sure why Windows Export all symbols was chosen as well.

[skupr-anaconda]

LGTM but you can use ninja-base instead of ninja

[danpetry]

I do not know why static libs are included in the package for windows and not unix.

I am not sure why Windows Export all symbols was chosen as well.

ok, I don't think it's a big deal, the package isn't used anywhere at the moment

[ryanskeith]

I found out why windows exports are the way they are found in this issue that is yet to be resolved: zlib-ng/minizip-ng#475