-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display useful build info for dev builds, both inside the app and in Firebase App Distribution #333
Comments
I have started working on the Android-part of this problem on the branch feature/duckth/add-debug-build Not sure where to begin with iOS though! |
@duckth While I only have lightly skimmed the documentation using the Flutter feature Flavours could maybe solve what we're trying to achieve here. See relevant documentation |
@jonasanker I initially used flavours to set it up but deemed it overkill as the build type seemed to get the job done, but the flavorizr package does seem pretty clean. Though, it requires Ruby for some reason so this might complicate things - maybe we could run it in a container? |
Yea, it requires Ruby on iOS specifically. We are able to add Ruby (if not already existing) to the GitHub mac build agent if needed. On Android, it should work out of the box according to documentation. |
AFAIK there’s no way to do this on iOS. Right now we have the -prod suffix on Android builds for production. (I think -dev suffix for other builds as well; need to confirm!) |
This is how I see the issue currently:For a long time, app builds off the
Ideally, I would get an email notifying me of a new app version |
The challenge here is that we only apply a tag for production releases on the production branch. This tag is not visible for the We might be able to solve this by either merging production to develop (should be investigated) or querying for it through the GitHub API. Maybe we should reflect on what is useful to have as a developer. When you want to test the app, what information do you need to be able to correlate to the commit? Would that be the pipeline execution Id which built the app, is it the commit of the app or others? I am wondering that maybe having a bump of the latest production release is not the right problem we are solving.. To give an example if you have X build after 3.4-build, what does that tell? It doesn't make you able to point to which develop build the app is. You just know that it is a later build than what was in production. But maybe that is also alright. I'm just thinking out loud 😊 |
Include commit hash in the version name? For instance, for the app built on branch
This could be further expanded for other branches as well. Let's say I have a pull request that wants to merge branch
|
I like the idea of having the option to create a test release from feature branches too. Maybe the version is not really necessary in development at all? A feature branch can quickly become several versions behind and then the version name would be misleading. On top of my head, I would suggest this naming pattern like this
|
still required for useful iOS version naming |
No description provided.
The text was updated successfully, but these errors were encountered: