You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In both the Footer and LineupCard components we have a case for displaying a social link <img> wrapped in an <a> tag with standard attributes like title, alt, href, etc.
Thus it would be nice to create something like <bf-social-icon> that handle all of the combined <a> and <img> tag logic, and rendering the correct social link, and "forwarding" things like href and title.
Would also want to pull out some the specs from LineupCard since for testing actual values, those would probably better belong in this new SocialLinkIcon component.
Somewhat related, we may also want to consider re-sizing these social link images too, since they are currently sized to 40px by 40px, so if a user magnifies the page, those can get a little blurry. Not a big deal, but a nice to have if "flexible" sizing is needed / desired.
The text was updated successfully, but these errors were encountered:
Summary
In both the
Footer
andLineupCard
components we have a case for displaying a social link<img>
wrapped in an<a>
tag with standard attributes liketitle
,alt
,href
, etc.Details
Thus it would be nice to create something like
<bf-social-icon>
that handle all of the combined<a>
and<img>
tag logic, and rendering the correct social link, and "forwarding" things likehref
andtitle
.Would also want to pull out some the specs from
LineupCard
since for testing actual values, those would probably better belong in this newSocialLinkIcon
component.Somewhat related, we may also want to consider re-sizing these social link images too, since they are currently sized to

40px
by40px
, so if a user magnifies the page, those can get a little blurry. Not a big deal, but a nice to have if "flexible" sizing is needed / desired.The text was updated successfully, but these errors were encountered: