Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create reusable social link icon component #11

Open
thescientist13 opened this issue Jun 6, 2023 · 0 comments
Open

create reusable social link icon component #11

thescientist13 opened this issue Jun 6, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thescientist13
Copy link

thescientist13 commented Jun 6, 2023

Summary

In both the Footer and LineupCard components we have a case for displaying a social link <img> wrapped in an <a> tag with standard attributes like title, alt, href, etc.

<a
  href="${link}"
  title="${formattedTitle}"
>
  <img
    src="/assets/images/${label}-icon.png"
    alt="${formattedTitle}"
    width="40"
    height="40"
    loading="lazy"
  />
</a>

Screen Shot 2023-06-05 at 9 58 00 PM
Screen Shot 2023-06-05 at 9 58 20 PM

Details

Thus it would be nice to create something like <bf-social-icon> that handle all of the combined <a> and <img> tag logic, and rendering the correct social link, and "forwarding" things like href and title.

Would also want to pull out some the specs from LineupCard since for testing actual values, those would probably better belong in this new SocialLinkIcon component.


Somewhat related, we may also want to consider re-sizing these social link images too, since they are currently sized to 40px by 40px, so if a user magnifies the page, those can get a little blurry. Not a big deal, but a nice to have if "flexible" sizing is needed / desired.
Screen Shot 2023-06-05 at 10 00 57 PM

@thescientist13 thescientist13 added enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2023
@thescientist13 thescientist13 transferred this issue from AnalogStudiosRI/www.blissfestri.com Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant