fix: unable to pass odd number to genRandomChar (#2403)

pplulee · web-flow · commit 8aba3ae1eb0b · 2024-04-01T20:12:05.000-07:00
* fix: unable to pass odd number to genRandomChar
diff --git a/src/Utils/Tools.php b/src/Utils/Tools.php
@@ -186,7 +186,8 @@ public static function genRandomChar(int $length = 8): string
             $length = 2;
         }
 
-        return bin2hex(openssl_random_pseudo_bytes($length / 2));
+        $randomString = bin2hex(openssl_random_pseudo_bytes((int) ceil($length / 2)));
+        return substr($randomString, 0, $length);
     }
 
     public static function genSs2022UserPk(string $passwd, string $method): string|false

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,8 @@ public static function genRandomChar(int $length = 8): string`
`186`	`186`	`$length = 2;`
`187`	`187`	`}`
`188`	`188`
`189`		`- return bin2hex(openssl_random_pseudo_bytes($length / 2));`
	`189`	`+ $randomString = bin2hex(openssl_random_pseudo_bytes((int) ceil($length / 2)));`
	`190`	`+ return substr($randomString, 0, $length);`
`190`	`191`	`}`
`191`	`192`
`192`	`193`	`public static function genSs2022UserPk(string $passwd, string $method): string\|false`