Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Android popup selection dialog covers the editor menu making it impossible to use #1067

Closed
agrogers opened this issue May 15, 2021 · 10 comments

Comments

@agrogers
Copy link
Contributor

agrogers commented May 15, 2021

AndBible Suggestions-editor v2

@bvahedy
Copy link

bvahedy commented May 15, 2021

You should be able to tap and hold on the "selection dialog" and move it out of the way.
I don't believe this is a bug.

@bvahedy bvahedy removed their assignment May 15, 2021
@tuomas2
Copy link
Contributor

tuomas2 commented May 15, 2021

In some android devices it is possible, with some it is not. Confirmed it works on my tablet, but does not work on emulator (struggled with this when doing beta video)

@tuomas2
Copy link
Contributor

tuomas2 commented May 15, 2021

I agree that selection popup is disturbing when trying to access buttons and something needs to be done. I believe @agrogers 's idea is worth trying, though I'm not sure if it will work out well or not (popup is not totally in our hands as it's Android's stuff).

@agrogers
Copy link
Contributor Author

agrogers commented May 15, 2021 via email

@agrogers
Copy link
Contributor Author

If this issue only affects a minority of users then i say leave it for later. Otherwise it feels bad enough to try to address. Unless my note is more than a few lines long then the cool edit tools are useless. (Of course not if i format before I type - there are cumbersome ways around it)

Include this feature in v3.4.

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 25, 2021

Implementation problem: we can't open selection context menu (copy etc) manually (tried this hard when trying to do #1079). It can come only as a consequence of selection text.

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 25, 2021

The thing is right now that I don't know what to do witht his. I would have fixed this months ago if it was easy to fix neatly.

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 6, 2021

Option to "hide" or "close" the context menu might work as a workaround/solution.

@agrogers
Copy link
Contributor Author

agrogers commented Jul 7, 2021 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Aug 2, 2021

This is now fixed by moving toolbar to the bottom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants