Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important keyboard shortcuts #2622

Open
7 of 16 tasks
tuomas2 opened this issue Jun 10, 2023 · 3 comments
Open
7 of 16 tasks

Important keyboard shortcuts #2622

tuomas2 opened this issue Jun 10, 2023 · 3 comments
Labels
Affects: Alpha Type: Bug

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 10, 2023 •
edited
Loading

Related: #1878 #1960 #60

  • Go to find (ctrl+f)
  • Go to bible book selector (ctrl+b)
  • Ctrl+b should still work for bolding text in text editors #3042
  • plus button in one-tap dialog
  • when tts panel is visible, space should toggle play/pause
  • workspace selector ctrl+w?
  • minimize window key binding?
  • progressing ( and scrolling when necessary) with keyboard one ordinal (or verse) at time, and then enter key opening bookmark amb modal. Arrow keys would be natural but maybe that would not be good default behavior?
  • when one-tap modal is open, arrow keys could move up/down in verses and shift+up/down could also select upper/lower verses?
  • Make wiki page about how to use AndBible efficiently with keyboard, and link from / to Waydroid setup page
  • Help dialog should list keyboard bindings and perhaps printable cheat sheet would be nice too
  • Add tooltip to buttons if there is keyboard binding to that function
  • If verse is highlighted in the beginning, plus button should select one more verse and pop up single tap dialog.
  • Minus button should reduce selection by one
  • alt+arrow buttons move focus to other window. But when focus is moved to another window that has text edit active, you can't directly write tet to that text edit. Focus should be to text edit directly. Also it sometimes jumps to the beginning of document, which is not desired.
  • esc key is harmful as it is "back key" and it is bound to going back in history. Should be able to disable that behavior for back key (perhaps a setting) and do history navigation some other way (perhaps overlay buttons)
@timbze
Copy link
Contributor

timbze commented Jun 11, 2023

Ctrl + c would be nice to have when verse is selected (modal is showing). It should copy with current copy settings i.e. the settings that are selected when pressing "Share" on the modal.

@timbze timbze mentioned this issue Aug 14, 2023
Merged
@tuomas2 tuomas2 moved this from Needs triage to Pre-5.0 in Tuomas' project board Aug 26, 2023
@tuomas2 tuomas2 moved this from Pre-5.0 to Pre-5.0 lower in Tuomas' project board Sep 14, 2023
tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Implement space toggles speak (#2622)
a7567f5
tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Handle physical plus key in ambiguous modal dialog #2622
abb93b9
tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Implement key chooser with Ctrl+B #2622
4a0ad41
@tuomas2
Copy link
Contributor Author

tuomas2 commented Oct 12, 2023 •
edited
Loading

bookmark amb modal:

  • b: add bookmark
  • n: add note
  • space: start speaking

also: when pressing b when there's a selection, should make bookmark. (and note similarly).

tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Fix plust key handling #2622
0a57c36
tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Add key bindings to bookmark ambiguous modal (one tap modal) #2622
194fe5a
@tuomas2 tuomas2 moved this from Pre-5.0 lower to Pre-5.0 in Tuomas' project board Oct 12, 2023
tuomas2 added a commit that referenced this issue Oct 12, 2023
@tuomas2
Do not execute multiple keyboard handlers, and allow handlers to have…
eb9484d 
… priorities. #2622
@github-project-automation github-project-automation bot moved this from Pre-5.0 to Closed in Tuomas' project board Oct 12, 2023
@tuomas2 tuomas2 reopened this Oct 12, 2023
@github-project-automation github-project-automation bot moved this from Closed to Needs triage in Tuomas' project board Oct 12, 2023
@tuomas2 tuomas2 moved this from Needs triage to Pre-5.0 in Tuomas' project board Oct 12, 2023
@tuomas2
Copy link
Contributor Author

tuomas2 commented Oct 17, 2023

ctrl+b should make text bold in text view and is conflicting

tuomas2 added a commit that referenced this issue Oct 19, 2023
@tuomas2
Add minus button handling to one tap dialog (#2622)
280bbfc
tuomas2 added a commit that referenced this issue Nov 16, 2023
@tuomas2
Add shortcut ctrl+w for workspace selector #2622
6a50039
@tuomas2 tuomas2 moved this from Prio 2 to Prio 3 in Tuomas' project board Nov 16, 2023
@timbze timbze mentioned this issue Jun 19, 2024
Closed
@github-project-automation github-project-automation bot moved this to Needs triage in Ben's project board Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Alpha Type: Bug
Projects
Ben's project board
Status: Needs triage
Tuomas' project board
Status: Prio 3
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuomas2 @timbze