Full search result list even if there are more than 1000 hits

[magdosandor]

Searching seems to restrict the result set to 1000. Still, when searching for very frequent terms (i.e. "Lord") it is not enough.

[agrogers]

When I made some code changes I increased the limit to 5000 and that was enough for most searches. There was a very small delay on my phone but was not an issue. I dont see why the limit could not be significantly increased.

…

___________________________ *www.TenOutOfTen.org* <https://www.TenOutOfTen.org> ***@***.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Wed, 24 Apr 2024 at 00:36, magdosandor ***@***.***> wrote: Searching seems to restrict the result set to 1000. Still, when searching for very frequent terms (i.e. "Lord") it is not enough. — Reply to this email directly, view it on GitHub <#3241>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKGTJVKFVMNTBMF5HMN6IDY62PJTAVCNFSM6AAAAABGVNPAN2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TSNBWG42DAMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[tuomas2]

I can change limit to 5000 as first aid.

For better solution:

It could be done also fully dynamic, i.e. without limits. Should modernize the implementation of search results from ListView to RecyclerView, which dynamically loads more content when scrolling. Would require quite a lot of refactoring of existing code though.

[tuomas2]

limit change from 1000 to 5000 ac3e7b1

[Noitarud]

Just informing you that 1001 results take a long time to load when "Open results in a window" is chosen (concept from #2024?), al least add warning here or request result range to include (500 items default). Closing offending window does not terminate task. Giving more options to refine search would help most cases #186.

[tuomas2]

Just informing you that 1001 results take a long time to load when "Open results in a window" is chosen (concept from #2024?), al least add warning here or request result range to include (500 items default). Closing offending window does not terminate task. Giving more options to refine search would help most cases #186.

Does it show loading spinner or does it freeze app when loading?