Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ALLOW_VISUAL_REGRESSION_TO_FAIL flag #16

Open
JamesCatt opened this issue Apr 14, 2023 · 1 comment
Open

Support ALLOW_VISUAL_REGRESSION_TO_FAIL flag #16

JamesCatt opened this issue Apr 14, 2023 · 1 comment
Assignees
@JamesCatt
Labels
enhancement New feature or request

Comments

@JamesCatt
Copy link

The upstream cypress-visual-regression plugin that this is based on has a ALLOW_VISUAL_REGRESSION_TO_FAIL config flag to allow the Cypress tests to pass even if a diff over the threshold is detected, but it looks like this isn't supported on this fork.

Was hoping to make use of this feature. Happy to provide a PR if you'll accept one.
@Andremoniy
Copy link
Owner

hi @JamesCatt ,
Sure, feel free to provide a PR. Just don't forget to add tests.

@Andremoniy Andremoniy added the enhancement New feature or request label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesCatt JamesCatt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andremoniy @JamesCatt