-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some "Character Develomemnt Items" lines are missing and some numbers are wrong. #174
Comments
I'll answer this in parts: Your issue with the incorrectly parsed numbers is a known issue. I've found that some digits (namely 1 and 4) sometimes trip up the scanner due to their size and font. There is some we can do to improve accuracy but it will take some time without some sort of standardized way of submitting inaccuracies. Rows/columns of items being skipped might be a result of the blurred background interfering with locating items on the screen. Usually moving around in the world can be enough to fix this. At the point in which the scanner stopped short of scanning the rest of your inventory, did it start scanning from bottom to top, right to left? All the materials sections of the scanner rely on reading the item on the right side of the screen. Sometimes it clicks too fast and the next item hasn't been clicked by the time the scanner checks to see what item is there. Please increase the delay a bit and let me know if the issue with stopping short continues. |
I set the display mode of GI as "1600x900 Windowed". The scanner delay was already set on 100ms. I noticed that the kamera doesn't go down enough. When it goes from the bottom to the top, the frame where the number is, is shadowed with the background and half of the number is visible. |
We check for when we are attempting to scan something that's already been scanned to determine if we're near the bottom of the inventory page. At which point we do a number of scrolls to ensure the lines of items have their quantities visible. Obviously if Kamera stops short of the bottom then there's a good chance that those last few rows can't get their quantities scanned since they're not completely visible. Does this incorrect behavior happen on other resolutions for you? Thanks for the feedback. We will continue to look for more optimized ways for material scanning. |
Yes, I tried different resolutions with no much luck. |
As of version 1.2.3, can confirm that neither 1280x720 nor 1600x900 worked well with char development items nor materials scanning on my end
Can also confirm those numbers seemingly cause errors a lot more often than others Error logs
|
I am marking this a Duplicate of #96 to consolidate issues |
Hello,
I get count errors or missing in "Character Develomemnt Items"
For exemple, my "SergeantsInsignia" count is 11 and Inventory_Kamera tells its 1.
Some lines are missing, like one line containing in my inventory "whopperflowernectar, shimmeringnectar, sturdyboneshard, fragileboneshard, kageuchihandguard,oldhandguard,chaosaxis".
View in my Genshin Impact:
View of the generated GOOD file in genshin-center.com
My PhilosophiesOfFreedom count is 2, but Inventory_Kamera tells its 11.
The rest (7 lines) after PhilosophiesOfFreedom is not taken in account
View in my Genshin Impact:
View of the generated GOOD file in genshin-center.com :
I'm using Inventory_KameraV1.1.1-prerelease.
The text was updated successfully, but these errors were encountered: