Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 HIGH VULNERABILITIES #1914

Closed
Legends-of-NGDB opened this issue Jun 8, 2024 · 4 comments
Closed

2 HIGH VULNERABILITIES #1914

Legends-of-NGDB opened this issue Jun 8, 2024 · 4 comments
Labels
dependencies Pull requests that update a dependency file vulnerability

Comments

@Legends-of-NGDB
Copy link

Run npm i discord-player@latest in your terminal.

NPM says:

94 packages are looking for funding

2 high severity vulnerabilities

@Legends-of-NGDB Legends-of-NGDB added the bug Something isn't working label Jun 8, 2024
@zipperdev
Copy link

+1

The NPM audit report is as follows:

# npm audit report

ip  *
Severity: high
ip SSRF improper categorization in isPublic - https://github.com/advisories/GHSA-2p57-rm9w-gvfp
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/ip
  discord-player  >=6.6.3-dev.0
  Depends on vulnerable versions of ip
  node_modules/discord-player

2 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

@retrouser955
Copy link
Collaborator

Temp fix. Use the latest discord-player but do not use the IP rotator.

@twlite
Copy link
Collaborator

twlite commented Jun 9, 2024

@zipperdev @Legends-of-NGDB we are using the latest version of ip package, so we cant do anything until they fix it first. On the other hand, your bot won't have issues running it because the issue here is ip package classifying private ip as public, which is out of scope for discord-player. IP related code is here https://github.com/Androz2091/discord-player/blob/master/packages/discord-player/src/utils/IPRotator.ts and it is only used to generate random ip address based on the block you have specified (only if you are using ip rotation feature)

@twlite twlite added dependencies Pull requests that update a dependency file vulnerability and removed bug Something isn't working labels Jun 9, 2024
@twlite
Copy link
Collaborator

twlite commented Aug 6, 2024

should be done in latest version. You are required to install ip package yourself if you want ip rotation stuff

@twlite twlite closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file vulnerability
Projects
None yet
Development

No branches or pull requests

4 participants