This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Explore `continue` in Vault harvest method #272

Open

stevieraykatz opened this issue Aug 7, 2023 · 0 comments

Labels

Audit

Contributor

stevieraykatz commented Aug 7, 2023

From auditor:

I noticed in contracts/core/vault/APVault_V1.sol there is a for loop and it does a return rather than a continue:
if (baseTokenValue <= principleByAccountId[accountId].baseToken) {
return;
Is that as intended? Other accounts may still be harvestable?

stevieraykatz added the Audit label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.