Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make site logo configurable #70

Closed
wants to merge 1 commit into from
Closed

Make site logo configurable #70

wants to merge 1 commit into from

Conversation

metbril
Copy link

@metbril metbril commented Nov 3, 2019

Make site logo configurable, just like in the h-card.

Make site logo configurable, just like in the h-card.
@AngeloStavrow
Copy link
Owner

AngeloStavrow commented Nov 4, 2019

Hey @metbril, thanks for opening this PR! Per the Contributing guide, I opened #71 for you to discuss what your goal for this change is. Care to share your thoughts there?

@AngeloStavrow AngeloStavrow added the wip Work in progress label Nov 4, 2019
@metbril
Copy link
Author

metbril commented Nov 6, 2019

Well the PR description says it all.

Make site logo configurable, just like in the h-card.

@AngeloStavrow
Copy link
Owner

Well the PR description says it all.

Make site logo configurable, just like in the h-card.

Fair enough. ¯\_(ツ)_/¯

Okay, so this PR will make the site logo (a static asset) identical to the profile picture that goes in the author bio (which gets set in config.toml). Certainly, I can imagine some people wanting their face as the site logo, but this doesn't feel like the best way to achieve your goal without breaking the theme for others.

The site logo is (currently) configurable by creating your own logo as an SVG, and replacing the Indigo logo in /static/images/site-logo.svg. This isn't documented anywhere, and that's my bad! It also forces an SVG on people, so that's potentially unpleasant.

For maximum flexibility, I'd instead recommend creating another entry in config.toml for e.g. Site.Params.SiteLogo and having /layouts/partials/header.html point to that.

Want to take a crack at that?

@AngeloStavrow
Copy link
Owner

Closing this stale PR. Feel free to re-open if you want to take a crack at the requested changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants