Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the project to december 2018 #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexbjorlig
Copy link

@alexbjorlig alexbjorlig commented Dec 5, 2018

I created a PR that targets #2, and several other small issues I found when using this example in december 2018:

  1. Removed the dependency to Google Cloud storage (instead using the built in firebase-admin)
  2. Updated a comment in code regarding Promise.all()
  3. Improved the naming of the temporary file, to include a random number. This should help solve an issue I experienced myself, where the snapshots are generated of an old picture (also referenced in the blog).
  4. Added metadata, so it works for both jpg, jpeg, png etc.

Let me know what you think 😎

@hellseyfer
Copy link

thank u a lot, it is compiling after some dependencies updates but it wont resize my images lol

@alexbjorlig
Copy link
Author

Hi @hellseyfer - what error do you get? Maybe you could share your repo?

@hellseyfer
Copy link

Hi @hellseyfer - what error do you get? Maybe you could share your repo?

I tested with a new upload and it worked but not the old ones

@alexbjorlig
Copy link
Author

@hellseyfer since this code is "reactive" I would say that's intended behaviour 😄

@hellseyfer
Copy link

Alright, good job~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants