{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":603198991,"defaultBranch":"master","name":"dbft","ownerLogin":"AnnaShaleva","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-02-17T20:39:10.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/22775709?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1678186668.457679","currentOid":""},"activityList":{"items":[{"before":"63333f9a586195454df0b7b481d00de457c11471","after":"a0b2f7f953969e2c2c3595a9bd9b8aec861ec768","ref":"refs/heads/fix-count-committed","pushedAt":"2023-03-15T14:17:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"context: fix the way how committed/failed nodes are counted\n\nIt's an error to count the same node twise (as committed and as failed,\nconsider the case of node committed at the previous view). Note, that C#\nimplementation doesn't have such problem, because of different \"failed\"\nnode definition (the node that haven't sent any messages in the current\nheight).","shortMessageHtmlLink":"context: fix the way how committed/failed nodes are counted"}},{"before":"9c09550f794f7a92905db1838771cf51596aec64","after":"63333f9a586195454df0b7b481d00de457c11471","ref":"refs/heads/fix-count-committed","pushedAt":"2023-03-15T14:16:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"context: fix the way how committed/failed nodes are counted\n\nIt's an error to count the same node twise (as committed and as failed,\nconsider the case of node committed at the previous view). Note, that C#\nimplementation doesn't have such problem, because of different \"failed\"\nnode definition (the node that haven't sent any messages in the current\nheight).","shortMessageHtmlLink":"context: fix the way how committed/failed nodes are counted"}},{"before":"36dc772ad83dcf1fe3f4a115d278c1c2f0af2711","after":"9c09550f794f7a92905db1838771cf51596aec64","ref":"refs/heads/fix-count-committed","pushedAt":"2023-03-15T11:15:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"context: fix the way how committed/failed nodes are counted\n\nIt's an error to count the same node twise (as committed and as failed,\nconsider the case of node committed at the previous view). Note, that C#\nimplementation doesn't have such problem, because of different \"failed\"\nnode definition (the node that haven't sent any messages in the current\nheight).","shortMessageHtmlLink":"context: fix the way how committed/failed nodes are counted"}},{"before":"e90389d64a8aa6c33a1dab40ce9a6b27e3cd0ba7","after":"36dc772ad83dcf1fe3f4a115d278c1c2f0af2711","ref":"refs/heads/fix-count-committed","pushedAt":"2023-03-14T16:04:42.077Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"context: fix the way how committed/failed nodes are counted\n\nIt's an error to count the same node twise (as committed and as failed,\nconsider the case of node committed at the previous view). Note, that C#\nimplementation doesn't have such problem, because of different \"failed\"\nnode definition (the node that haven't sent any messages in the current\nheight).","shortMessageHtmlLink":"context: fix the way how committed/failed nodes are counted"}},{"before":"39e3e95e00f5b6a4247dbb48761cda4a92da085a","after":"b769eb3e0f070d6eabb9443a5931eb4a2e46c538","ref":"refs/heads/master","pushedAt":"2023-03-13T09:45:04.265Z","pushType":"push","commitsCount":5,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"Merge pull request #4 from AnnaShaleva/external-new-block-init\n\ncheck: make the user's duty to init consensus at the next height","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"531173057\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nspcc-dev/dbft/issues/4\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nspcc-dev/dbft/pull/4/hovercard\" href=\"https://github.com/nspcc-dev/dbft/pull/4\">nspcc-dev#4</a> from AnnaShaleva/external-new-block-init"}},{"before":"7b114b072167a9179ef871cbea107f5725f6808d","after":"1abf89d232ee20d1d385b802c55ca1ac44f0f660","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-13T07:42:10.107Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"dbft: fix typo","shortMessageHtmlLink":"dbft: fix typo"}},{"before":"37fee15d671d00d8a4419f7b9afe0e396a7675d1","after":"7b114b072167a9179ef871cbea107f5725f6808d","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-10T14:05:14.358Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"dbft: fix typo","shortMessageHtmlLink":"dbft: fix typo"}},{"before":"4ea7cea1c614cb201cb430919bd93cf257337bf7","after":"37fee15d671d00d8a4419f7b9afe0e396a7675d1","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-09T16:12:00.293Z","pushType":"push","commitsCount":3,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"dbft: fix typo","shortMessageHtmlLink":"dbft: fix typo"}},{"before":"9fbf587f83a1248b9bc59e37d0a3eedbe1aba22f","after":"4ea7cea1c614cb201cb430919bd93cf257337bf7","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-09T10:22:59.586Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"check: make the user's duty to init consensus at the next height\n\nIt's OK to notify the user about the block collected and do not change\nthe context's state immediately. The user will handle new block and\ncall `InitializeConsensus` by itself like he already does when\nthe new block comes from the other source (e.g. network/RPC). The consensus\nwon't perform any further actions anyway before the next call to\n`InitializeContext`. The described way of responsibility distribution\nleads to clear and predictable behaviour and cleaner user's handlers\ncode.\n\nMoreover (it's not an argument, but yet another valid reason to apply\nthis commit), the C# dBFT plugin does the same thing. It leaves the\ninitialization to the `OnPersistCompleted` callback and does not\ninitialize consensus at the new heigh immediately after Commits checks.\nSee the https://github.com/neo-project/neo-modules/blob/52122bd286b0a9854ded648516bb223a8ecb4d2e/src/DBFTPlugin/Consensus/ConsensusService.Check.cs#L64\nand\nhttps://github.com/neo-project/neo-modules/blob/52122bd286b0a9854ded648516bb223a8ecb4d2e/src/DBFTPlugin/Consensus/ConsensusService.cs#L75.\n\nIt should be noted that it's still the dBFT's duty to initialize consensus\nat the next non-zero view (e.g. on collecting M ChangeViews), because it\nis the direct operation of the consensus algorithm.","shortMessageHtmlLink":"check: make the user's duty to init consensus at the next height"}},{"before":"d7f731afb0beef1531aad790dac95d9d1abb2624","after":"9fbf587f83a1248b9bc59e37d0a3eedbe1aba22f","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-09T10:19:48.737Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"check: make the user's duty to init consensus at the next height\n\nIt's OK to notify the user about the block collected and do not change\nthe context's state immediately. The user will handle new block and\ncall `InitializeConsensus` by itself like he already does when\nthe new block comes from the other source (e.g. network/RPC). The consensus\nwon't perform any further actions anyway before the next call to\n`InitializeContext`. The described way of responsibility distribution\nleads to clear and predictable behaviour and cleaner user's handlers\ncode.\n\nMoreover (it's not an argument, but yet another valid reason to apply\nthis commit), the C# dBFT plugin does the same thing. It leaves the\ninitialization to the `OnPersistCompleted` callback and does not\ninitialize consensus at the new heigh immediately after Commits checks.\nSee the https://github.com/neo-project/neo-modules/blob/52122bd286b0a9854ded648516bb223a8ecb4d2e/src/DBFTPlugin/Consensus/ConsensusService.Check.cs#L64\nand\nhttps://github.com/neo-project/neo-modules/blob/52122bd286b0a9854ded648516bb223a8ecb4d2e/src/DBFTPlugin/Consensus/ConsensusService.cs#L75.","shortMessageHtmlLink":"check: make the user's duty to init consensus at the next height"}},{"before":"8b4771d6ada8f16741516cef54cbdd73f1ed1982","after":null,"ref":"refs/heads/addblock-lock","pushedAt":"2023-03-07T10:57:48.457Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"}},{"before":null,"after":"d7f731afb0beef1531aad790dac95d9d1abb2624","ref":"refs/heads/external-new-block-init","pushedAt":"2023-03-07T10:56:23.478Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"check: make the user's duty to init consensus at the next height","shortMessageHtmlLink":"check: make the user's duty to init consensus at the next height"}},{"before":null,"after":"8b4771d6ada8f16741516cef54cbdd73f1ed1982","ref":"refs/heads/addblock-lock","pushedAt":"2023-03-07T10:54:26.213Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"AnnaShaleva","name":"Anna Shaleva","path":"/AnnaShaleva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22775709?s=80&v=4"},"commit":{"message":"consensus: enqueue newly created blocks\n\nDo not add them directly to chain, it will be done by the block queue\nmanager. Close https://github.com/nspcc-dev/neo-go/issues/2923.","shortMessageHtmlLink":"consensus: enqueue newly created blocks"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0wMy0xNVQxNDoxNzo0NC4wMDAwMDBazwAAAAMEC2jY","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wMy0xNVQxNDoxNzo0NC4wMDAwMDBazwAAAAMEC2jY","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wMy0wN1QxMDo1NDoyNi4yMTMzNDVazwAAAAL-GkJf"}},"title":"Activity · AnnaShaleva/dbft"}