Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override minimum_cruise_ratio some times #62

Closed
vit-sh opened this issue Apr 23, 2024 · 2 comments
Closed

override minimum_cruise_ratio some times #62

vit-sh opened this issue Apr 23, 2024 · 2 comments

Comments

@vit-sh
Copy link

vit-sh commented Apr 23, 2024 •
edited
Loading

Test configuration file with script in the test.zip archive. The script cyclically launches klipper_estimate with a dump into a configuration file with the launch number. The result is in the resilt.zip archive. The default value for the max_accel_to_decel parameter is periodically substituted (files 3,4,7,11,14,18,19).
test.zip
result.zip

PS. the same result in the linux version
dalegaard added a commit that referenced this issue Apr 27, 2024
@dalegaard
Fix confusion with accel-to-decel/minimum-cruise-ratio config option
dbcff4a 
As documented in #61 and #62, there are issues with the config being all
wrong when reading this. It appears to be caused by some kind of
internal data race in Config. Refactor to have separate fields for the
two options and recalculate accel_to_decel as appropriate.
@dalegaard dalegaard mentioned this issue Apr 27, 2024
Closed
@dalegaard
Copy link
Collaborator

Hi @vit-sh

This should be fixed now. Can you confirm on latest release?

Best regards,
Lasse

@vit-sh
Copy link
Author

vit-sh commented Apr 28, 2024

I confirm. Everything works perfectly.

@vit-sh vit-sh closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalegaard @vit-sh