Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banned_comment_phrases: Fix bug with strings #14

Open
AnnikaCodes opened this issue Jul 29, 2023 · 0 comments
Open

banned_comment_phrases: Fix bug with strings #14

AnnikaCodes opened this issue Jul 29, 2023 · 0 comments

Comments

@AnnikaCodes
Copy link
Owner

Code like

some_code("hi! // <banned phrase>");

shouldn't trigger the linter. Probably ziglint should either get comments through the Zig AST/parsing process rather than its own, track strings starting/ending itself, or get string locations from AST and use that to avoid false positives in banned_comment_phrases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant