Fix inconsistent package requirements: typescript, @typescript-eslint/eslint-plugin, @typescript-eslint/parser` #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this commit to bump dependency minor versions seems to have caused two problems.
The first issue is simple: it caused
package.json
andpackage-lock.json
to get out-of-sync.The second issue is more complicated:
4.2.4
to4.5.5
@typescript-eslint/eslint-plugin
and@typescript-eslint/parser
are still on the4.x
line, and don't support typescript4.5.X
.The result is when
sls package
is run the following warning is printed to the console:To support typescript
4.5.X
,@typescript-eslint/eslint-plugin
and@typescript-eslint/parser
would need to be upgraded to the next major version.Until that's done, it might be a good idea to relax the version requirement on typescript to include the
4.4.X
line. That's what this PR does.This PR also updates
package-lock.json
so it's consistent withpackage.json
.