Set fully specified resolution rule to false in js loader #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Would just like to say thank you to those that maintain this project! It has saved me so much time over the years. I ran into a slight issue where I wasn't able to build my typescript es module project and this is the fix that allowed me to do so!
Looked around for how testing was done in the repo and noticed that the other usage of
fullySpecified
in thejavascript/auto
loader didn't have any corresponding tests so I didn't add any.Let me know what I need to do to get this PR up to spec and ready to be merged if it's the right approach for tackling this problem! :D
This is the error I was getting because I don't want to move to the new extension included import scheme as yet ::