Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fully specified resolution rule to false in js loader #306

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

carlswann
Copy link

Hello! Would just like to say thank you to those that maintain this project! It has saved me so much time over the years. I ran into a slight issue where I wasn't able to build my typescript es module project and this is the fix that allowed me to do so!

Looked around for how testing was done in the repo and noticed that the other usage of fullySpecified in the javascript/auto loader didn't have any corresponding tests so I didn't add any.

Let me know what I need to do to get this PR up to spec and ready to be merged if it's the right approach for tackling this problem! :D

This is the error I was getting because I don't want to move to the new extension included import scheme as yet ::

ERROR in ../../../backend/microservices/stripe-microservice/dist/src/main-serverless.js 3:0-72
Module not found: Error: Can't resolve './stripe-microservice.module' in '/Users/carlswann/src/tingsly/microservices/packages/backend/microservices/stripe-microservice/dist/src'
Did you mean 'stripe-microservice.module.js'?
BREAKING CHANGE: The request './stripe-microservice.module' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant