Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed successfully but changes not reflected in AWS account #46

Open
morganwalker opened this issue Jun 14, 2018 · 2 comments
Open

Comments

@morganwalker
Copy link

I've made the following changes:

  • commented out the following in core.py:
tags_to_set['instance_id'] = instance_id
tags_to_set['device'] = device
  • using this config:
---
region: us-east-1
_instance_tags_to_propagate:
  - 'Environment'

_volume_tags_to_propagate:
  - 'Environment'

_volume_tags_to_be_set:
#  -  key:   'role'
#     value: 'ebs'

_snapshot_tags_to_be_set:
#  -  key:   'role'
#     value: 'ebs_snapshot'

_instance_filter:
# Filter values with the same key (eg, tag:app) are an OR
# Different filter keys are an AND operation (eg, tag:app and tag:team)
# See the Filter section in http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html#API_DescribeInstances_RequestParameters
# Example entries:
#    'tag:app':   ['app1', 'app2']
#    'tag:team': 'team1'

_volumes_to_tag:
# An empty list means tag all volumes
# Example entries:
#  - 'vol-1ab2c345'
  - 'vol-0784cc294e20cbb39'

_snapshots_to_tag:
# An empty list means tag all snapshots
# Example entries:
#  - 'snap-12ab3c45'
#  - 'snap-6de7f890'
  • Running ./graffiti-monkey --config ../conf/example_config.yml --append --nosnapshots --dryrun tells me it is going to make the following changes, adding the Environment tag:
2018-06-13 20:24:08 [INFO] Starting Graffiti Monkey
2018-06-13 20:24:08 [INFO] Options: dryrun True, append True, novolumes False, nosnapshots True
2018-06-13 20:24:08 [INFO] Connecting to region us-east-1 using profile default
2018-06-13 20:24:08 [INFO] Using volume list from cli/config file
2018-06-13 20:24:09 [INFO] Found 1 volume(s)
2018-06-13 20:24:09 [INFO] Processing volume 1 of 1 total volumes
2018-06-13 20:24:09 [INFO] DRYRUN: Volume vol-0784cc294e20cbb39 would have been tagged {u'Name': u'kubernetes.metismachine.io-dynamic-pvc-46cc64b6-6a94-11e8-a763-02c1f252ba9e', u'kubernetes.io/created-for/pvc/namespace': u'spark-cluster', u'kubernetes.io/cluster/kubernetes.metismachine.io': u'owned', u'kubernetes.io/created-for/pvc/name': u'cassandra-data-cassandra-3', 'Environment': u'production', u'kubernetes.io/created-for/pv/name': u'pvc-46cc64b6-6a94-11e8-a763-02c1f252ba9e', u'KubernetesCluster': u'kubernetes.metismachine.io'}
2018-06-13 20:24:09 [INFO] Processed a total of 300 GB of AWS Volumes
2018-06-13 20:24:09 [INFO] Completed processing all volumes
2018-06-13 20:24:09 [INFO] Graffiti Monkey completed successfully!
  • However, when I run it without the --dryrun, it tells me it ran successfully but the EBS volume, the one in my config file, vol-0784cc294e20cbb39, the one in my AWS account, does not have the new Environment tag.
[20:24] jmorganwalker@ip-10-0-1-11:~DEV_ROOT/graffiti-monkey/bin# ./graffiti-monkey --config ../conf/example_config.yml --append --nosnapshots                                            master ✱ ◼
2018-06-13 20:24:29 [INFO] Starting Graffiti Monkey
2018-06-13 20:24:29 [INFO] Options: dryrun False, append True, novolumes False, nosnapshots True
2018-06-13 20:24:29 [INFO] Connecting to region us-east-1 using profile default
2018-06-13 20:24:29 [INFO] Using volume list from cli/config file
2018-06-13 20:24:30 [INFO] Found 1 volume(s)
2018-06-13 20:24:30 [INFO] Processing volume 1 of 1 total volumes
2018-06-13 20:24:30 [INFO] Processed a total of 300 GB of AWS Volumes
2018-06-13 20:24:30 [INFO] Completed processing all volumes
2018-06-13 20:24:30 [INFO] Graffiti Monkey completed successfully!
  • I tried running with -vvvvv and I can see it go through what seems to be a successful boto responses but still nothing in AWS

Any help would be greatly appreciated.

@SinghDivneet
Copy link

did you find a resolution to this ?

@aflatto
Copy link

aflatto commented Oct 15, 2019

I am having the same issue now, with the latest git code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants