Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support C++20 for release branch #1497

Closed
yarkinwho opened this issue Aug 15, 2023 · 2 comments
Closed

Support C++20 for release branch #1497

yarkinwho opened this issue Aug 15, 2023 · 2 comments

Comments

@yarkinwho
Copy link
Contributor

Contracts such as EOS-EVM rely on testers code in leap to build the unit tests. It would cause quite a lot trouble if the leap code does not support C++20 while some other libraries used by the unit tests start to switch to C++20.

@heifner
Copy link
Member

heifner commented Aug 15, 2023

For 4.0.x, I believe all that is needed is the removal of these lines: https://github.com/AntelopeIO/leap/pull/1070/files#diff-d81bca537ada1ccf67b84dc409d9a71010c9dfb14006b57c45adf09717bbbc9bL40-L44

Consider backporting this fix to release/4.0.

@spoonincode
Copy link
Member

As of 5.0 libtester is C++20. A change to the EVM testing environment to use libtester 5.0 is at eosnetworkfoundation/eos-evm-contract#681 so I think we can close this issue out as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants