Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Add integration test for transition from legacy consensus to IF consensus #1512

Closed
Tracked by #2110
arhag opened this issue Aug 17, 2023 · 1 comment
Closed
Tracked by #2110

IF: Add integration test for transition from legacy consensus to IF consensus #1512

arhag opened this issue Aug 17, 2023 · 1 comment
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@arhag
Copy link
Member

arhag commented Aug 17, 2023 •
edited
Loading

Depends on #1522 and #1548.

Many of the tests transition from pre-IF to IF to carry out the tests (see #1510). But they transition with 1 BP.

This integration test should test the transition with multiple BPs. To keep test runtime short, stick with 4 BPs.
@arhag arhag mentioned this issue Aug 17, 2023
Closed
@arhag arhag added this to the Leap v5.0.0-rc1 milestone Aug 17, 2023
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
@bhazzard bhazzard added this to the Leap v6.0.0-rc1 milestone Nov 1, 2023
@arhag arhag changed the title IF: Add integration test for transition from legacy consensus to HotStuff consensus IF: Add integration test for transition from legacy consensus to IF consensus Jan 10, 2024
@arhag arhag mentioned this issue Jan 19, 2024
Closed
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Feb 6, 2024
@linh2931 linh2931 removed their assignment Feb 6, 2024
@heifner heifner self-assigned this Feb 6, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Feb 6, 2024
heifner added a commit that referenced this issue Feb 6, 2024
@heifner
GH-1512 Refactor activateInstantFinality method so it can be called a…
22086f6 
…fter bootstrap
heifner added a commit that referenced this issue Feb 6, 2024
@heifner
GH-1512 Fix to handle bios and isProducer correctly
902c4c9
heifner added a commit that referenced this issue Feb 7, 2024
@heifner
GH-1512 Add transition_to_if.py test
59132ee
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-1512…
e7909e0 
…-if-transition-test
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
GH-1512 Expand integration test including a test for setprods after i…
b309617 
…nstant-finality enabled. Fix activation timing of new proposer policy.
@heifner heifner mentioned this issue Feb 8, 2024
Merged
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
Merge branch 'hotstuff_integration' into GH-1512-if-transition-test
93ea676
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
GH-1512 Fix comments
bd9a93e
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
GH-1512 Remove unneeded code
00a5615
heifner added a commit that referenced this issue Feb 8, 2024
@heifner
Merge pull request #2224 from AntelopeIO/GH-1512-if-transition-test
8440aea 
IF: Test: Transition to instant-finality with multiple producers
@heifner
Copy link
Member

heifner commented Feb 8, 2024

Resolved by #2224

@heifner heifner closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

No branches or pull requests
6 participants
@bhazzard @heifner @ericpassmore @arhag @linh2931 @enf-ci-bot