Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Ensure confirmed count in block header is zero after HotStuff transition #1580

Closed
Tracked by #2110
arhag opened this issue Aug 30, 2023 · 1 comment · Fixed by #2122
Closed
Tracked by #2110

IF: Ensure confirmed count in block header is zero after HotStuff transition #1580

arhag opened this issue Aug 30, 2023 · 1 comment · Fixed by #2122
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@arhag
Copy link
Member

arhag commented Aug 30, 2023 •
edited
Loading

Depends on #1523.

After HotStuff is enabled and the network has transition to it, proposers should create blocks with a confirmed value of zero, and validators should check that the value is zero.
@arhag arhag mentioned this issue Aug 30, 2023
Closed
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 30, 2023
@arhag arhag added 👍 lgtm and removed triage labels Aug 30, 2023
@bhazzard bhazzard added this to the Leap v6.0.0-rc1 milestone Nov 1, 2023
@arhag arhag mentioned this issue Jan 19, 2024
Closed
@heifner heifner self-assigned this Jan 22, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jan 22, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Jan 22, 2024
heifner added a commit that referenced this issue Jan 22, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-1580…
f9ab364 
…-confirmed
heifner added a commit that referenced this issue Jan 22, 2024
@heifner
GH-1580 confirmed == 0 after instant finality enabled
d750db9
@heifner heifner mentioned this issue Jan 22, 2024
Merged
@heifner heifner linked a pull request Jan 22, 2024 that will close this issue
IF: confirmed==0 after instant finality enabled #2122
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jan 22, 2024
heifner added a commit that referenced this issue Jan 22, 2024
@heifner
Merge pull request #2122 from AntelopeIO/GH-1580-confirmed
405ce52 
IF: confirmed==0 after instant finality enabled
@heifner
Copy link
Member

heifner commented Jan 22, 2024

Resolved by #2122

@heifner heifner closed this as completed Jan 22, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: confirmed==0 after instant finality enabled AntelopeIO/leap
4 participants
@bhazzard @heifner @arhag @enf-ci-bot