Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serialization of fixed-size arrays in abi_serializer. #1931

Open
greg7mdp opened this issue Nov 27, 2023 · 1 comment · May be fixed by #1918
Open

Support serialization of fixed-size arrays in abi_serializer. #1931

greg7mdp opened this issue Nov 27, 2023 · 1 comment · May be fixed by #1918
Labels
bug Something isn't working 👍 lgtm

Comments

@greg7mdp
Copy link
Contributor

It is not clear we want to do this. It would require support in abios as well, in addition to abi_serializer, and verify that it works with cdt and other tools.
@greg7mdp greg7mdp linked a pull request Nov 27, 2023 that will close this issue
Draft
@greg7mdp greg7mdp linked a pull request Nov 27, 2023 that will close this issue
Support serialization of fixed-size arrays in abi_serializer. #1918
Draft
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 27, 2023
@bhazzard
Copy link

bhazzard commented Dec 14, 2023 •
edited
Loading

Ultimately we will adopt a stricter serialization approach.

As a first step, let's merely determine whether this was introduced in a recent CDT version (antelope era). If so, we'll reconvene to discuss next steps. If not, we'll likely icebox this, at least until after 6.0

@bhazzard bhazzard added bug Something isn't working 👍 lgtm and removed triage labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 👍 lgtm
Projects
Team Backlog
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support serialization of fixed-size arrays in abi_serializer. AntelopeIO/leap
3 participants
@bhazzard @greg7mdp @enf-ci-bot