Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an easy way to disable automatic etherscan fetching when instanciating a Contract() #1939

Closed
Rozengarden opened this issue Feb 23, 2024 · 3 comments
Labels
category: feature New feature or request

Comments

@Rozengarden
Copy link

Overview

When creating a new contract instance via an address with the etherscan plugin installed additionals information such as abi are fetched on etherscan automagicaly (which is a really great feature).

However it looks like there is no way to disable this behaviour even when providing most of the infomations myself apart from directly uninstalling the etherscan plugin.

Specification

I don't see an easy way to implement this that doesn't involve footgun

Dependencies

I don't believe there are dependencies for this feature

@Rozengarden Rozengarden added the category: feature New feature or request label Feb 23, 2024
@fubuloubu
Copy link
Member

so, Contract excepts either a contract_type=... or an abi=... kwarg, which should bypass calling out to etherscan in order to fetch the contract type. further, if you have already downloaded the contract type, it should simply use the cached copy instead of calling out as well.

do you feel like this is not the case? does those kwargs help you for your use case?

@antazoey
Copy link
Member

fixed by #2401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants