Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeted Sound Effects #35

Open
taliyos opened this issue Mar 18, 2022 · 2 comments
Open

Targeted Sound Effects #35

taliyos opened this issue Mar 18, 2022 · 2 comments

Comments

@taliyos
Copy link
Collaborator

taliyos commented Mar 18, 2022

State Sound Effects should be targetable, by utilizing a new "target" field on each SoundEffect. To select a target, the user will provide the character id(s).

When the character plays against the targeted character, the character will use the special targeted sound effects instead of the normal ones.

Sections

  • UI Design
  • ID Creation [outside of the this issue]
  • SoundEffect interface modification
  • Character Creator Targeted SFX Implementation
@taliyos taliyos self-assigned this Apr 19, 2022
@taliyos
Copy link
Collaborator Author

taliyos commented Apr 19, 2022

I'm pretty sure that character IDs are no longer created (or at the very least, not shown to the user). It might be a good idea to switch this to the character name instead since the only other form of identification we have (the character download code) is only valid for 5 minutes.

@Apexal
Copy link
Owner

Apexal commented Apr 19, 2022

That makes sense to me. Note that the character code is actually character.id. We probably want to change that to code or a better name in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants