Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate duplicate class 'Material anatomical entity' #24

Open
dillerm opened this issue Jan 21, 2016 · 2 comments
Open

Deprecate duplicate class 'Material anatomical entity' #24

dillerm opened this issue Jan 21, 2016 · 2 comments

Comments

@dillerm
Copy link
Contributor

dillerm commented Jan 21, 2016

Will need to discuss what to do with its child classes. Presumably will end up moving some of them over to the other 'material anatomical entity' class, and deprecating the rest. Note that the UBERON import is NOT the one that should be deprecated, but the other duplicate beginning with a big 'M'.

@hoganwr
Copy link
Contributor

hoganwr commented Jan 21, 2016

The problem is that big 'M' material anatomical entity is imported from another ontology, where's it's doing important work. So it wouldn't be proper to obsolete it in Apollo-SV. Furthermore, the distinction between FMA and UBERON is that the former is specific to humans, the latter is not. So these classes probably do in fact, represent different types.

@dillerm
Copy link
Contributor Author

dillerm commented Jan 28, 2016

Right now the one imported from FMA doesn't have any annotations on it other than its label, so we'll probably want to re-import it and its subclass, which also only have labels (I checked Ontobee, and the class does have a definition). I think it's also worth mentioning that the definitions for this class are almost exactly the same--i.e., 'Physical anatomical entity which has mass' vs. 'Anatomical entity that has mass'. It's unfortunate that FMA hasn't defined 'immune system' yet since, if they did, it looks like we'd be able to just import their branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants