Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts of libmbus are too short on some cases #70

Closed
tsr8 opened this issue Mar 11, 2021 · 9 comments
Closed

Timeouts of libmbus are too short on some cases #70

tsr8 opened this issue Mar 11, 2021 · 9 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@tsr8
Copy link

tsr8 commented Mar 11, 2021

In my project I need longer timeouts in libmbus to work properly.

I can change source of libmbus and compile it and test it but:
how to compile node-mbus (need it in node-red)?

Resolved by myself using node-gyp:
node-gyp install node-gyp configure node-gyp build

@Apollon77
Copy link
Owner

WHy you do not make a PR in the libmbus project to have it adjusted there?

@tsr8
Copy link
Author

tsr8 commented Mar 12, 2021

Thank you for the answer.
They already have special "adjustable-timeout" branch for this, which adds "-t" parameter. I have created an libmbus issue: rscada/libmbus#186
I think that node-mbus shoud provide some setting to change timeouts easy way.

@Apollon77
Copy link
Owner

In fact thet PR is aloready included in their project and also in mine

https://github.com/Apollon77/libmbus/blob/build-windows/mbus/mbus-serial.c#L155

you need even higher values?

@tsr8
Copy link
Author

tsr8 commented Mar 12, 2021

you need even higher values?

By testing, I need minimum 1100ms at 2400 baudrate. It fails with 1000ms.

@Apollon77
Copy link
Owner

yes so it only makes sense to make it configurable completely ... puhhh ...

@stale
Copy link

stale bot commented Jun 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix This will not be worked on label Jun 10, 2021
@Apollon77 Apollon77 added enhancement New feature or request and removed wontfix This will not be worked on labels Jun 10, 2021
@Apollon77
Copy link
Owner

Timeout in generlsa can be ast as options.timeout already ... doyou reallyneed to adjust these "sub timeouts" or is the normalone enougth? Did you tried that?

@Apollon77 Apollon77 added question Further information is requested and removed enhancement New feature or request labels Jun 29, 2022
@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix This will not be worked on label Sep 28, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions.
Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.

@stale stale bot closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants