feat: time field time type and time tracks #5747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO this will need a better design later. |
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 540 | warning | contribute (via Fink 🐦) |
For now in mobile its only a textfield showing the final time. There is no add time track and tracking time feature.
* main: fix: integration test failed (grid row detail page: hide and show hidden fields) (AppFlowy-IO#5781) feat: ai billing (AppFlowy-IO#5741) fix: can not display rows when rows overthan 1000 (AppFlowy-IO#5777) feat: support publish database on web (AppFlowy-IO#5748) feat: publish databse to Web (AppFlowy-IO#5709) chore: update Spanish translations (AppFlowy-IO#5742) chore: update Chinese translations (AppFlowy-IO#5727) fix: Add retry for admin client sign in for test (AppFlowy-IO#5767) chore: update Hebrew translation (AppFlowy-IO#5738) chore: update German translations (AppFlowy-IO#5722) chore: update Russian translations (AppFlowy-IO#5730) chore: update build config (AppFlowy-IO#5759) chore: enable local ai and local ai chat (AppFlowy-IO#5755)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5747 +/- ##
===========================================
- Coverage 86.74% 72.90% -13.85%
===========================================
Files 217 240 +23
Lines 5032 6466 +1434
Branches 831 1042 +211
===========================================
+ Hits 4365 4714 +349
- Misses 561 1641 +1080
- Partials 106 111 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Time tracking button preview: time.tracking.mp4 |
|
Currently, the mobile app will only view the time field final time in a text field. If the design, functionality, etc is OK, I will also add complete functionality for mobile in the next PRs. |
zoli
force-pushed
the
feat/time-field-type-options
branch
2 times, most recently
from
e0d6a4b
to
d4f7e8d
Compare
zoli
force-pushed
the
feat/time-field-type-options
branch
from
d4f7e8d
to
2e88bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #4083 I added time type and precision for time field type. Now you can choose from edit property that the time type is "Plain Time", "Stopwatch" (count up), "Timer" (count down).
It's not completed yet tracking feature is missing plus some bug fixes. So I will make this a draft PR. Just wanted to add a preview here and maybe discuss some specifics.
IMO time field with tracking, count up, count down features along with some other features (i.e. calculating the total time of all rows) will help users to use AppFlowy as a To-do list with time tracking included.
Feature Preview
VID_20240716_213606_047.webm
PR Checklist